Use ASSIGNCOPY for NSAccessibilityElement string setters#398
Closed
Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] WIP addressing feedback on NSAccessibility implementations from PR #362
Use ASSIGNCOPY for NSAccessibilityElement string setters
Feb 17, 2026
Member
|
Does this make sens at all at a first glance? parameters are NSStrings and not mutable, aren't they? is there a deeper issue? |
Member
|
As the AI already explained, the parameter could as well be an NSMutableString, which is a sub class of NSString (Actually it is more complicated, as NSString is a class cluster, but we will ignore that for now). |
Member
|
This PR is outdated since I moved these into another class. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #362 to use
ASSIGNCOPYinstead ofASSIGNfor string attribute setters inNSAccessibilityElement.mto prevent issues with mutable strings being modified after assignment.Changes
setAccessibilityLabel:,setAccessibilityIdentifier:,setAccessibilityRole:, andsetAccessibilitySubrole:to useASSIGNCOPYinitWithRole:frame:label:parent:to useASSIGNCOPYfor role and label parametersThis prevents potential bugs where a caller passes an
NSMutableString, then mutates it after assignment.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.