428 fail to link on freebsd#429
Open
rmottola wants to merge 5 commits into
Open
Conversation
- use PKG_CHECK_MODULES upfront to test available libraries - add libswresample to libs and clfags
…CU and inotify. Add found flags to CONFIG_SYSTEM_* instead of GRAPHIC since strictly they are not. Upgrade header guard to correct HAVE_SYS_INOTIFY_H.
IOOI-SqAR
reviewed
May 13, 2026
Contributor
IOOI-SqAR
left a comment
IOOI-SqAR
left a comment
There was a problem hiding this comment.
I did not look at the details of the configure changes but tested it end to end on Ubuntu 24.04 ARM64, where it worked
Member
Author
|
Tested on:
|
fredkiefer
reviewed
May 14, 2026
Member
Author
|
I tested on all systems I could get hands on, no issues detected. Lars has also resolved his original issue which led to the ao workaround and confirms it still works. @fredkiefer addressed your minor cleanup and re-tested on 3 systems, with and without video libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tested on FreeBSD with full ICU and inotify
tested on Linux with Icu and not Inotify