Merged
Conversation
rustylocker
force-pushed
the
update-to-libosdp-3.1.0
branch
from
4116ec9 to
bfcefb3
Compare
Member
|
Thanks for this PR. It's a bit of work to review this, so will take it up over the weekend. |
rustylocker
force-pushed
the
update-to-libosdp-3.1.0
branch
from
e4cf595 to
1614ce7
Compare
Contributor
Author
|
In the meantime I did some testing and could NOT find any memory leaks in the command callback handling. @sidcha did you find time to have a look at this PR? |
sidcha
approved these changes
Dec 13, 2025
Member
sidcha
left a comment
sidcha
left a comment
There was a problem hiding this comment.
Hi @rustylocker thanks for the PR. Looks perfect.
sidcha
reviewed
Dec 13, 2025
…the application callback.
…nd make the members of "OsdpStatusReport" public so they can be accessed from the application callback
…PD`s input/output states
… since an all-zero buzzer command is invalid.
…version to 0.1.9.
sidcha
force-pushed
the
update-to-libosdp-3.1.0
branch
from
00195e2 to
3a12ecc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still needs some testing to ensure no dangling heap memory when application callback is invoked.