feat(core): add _warning field to KeyMeta and save_meta doc comment#161
Merged
Conversation
Add a _warning field to KeyMeta that serializes at the top of .meta JSON files, warning users and agents not to modify these files directly since they are HMAC-verified. Add a doc comment to save_meta documenting the meta-tag invariant: every call must be followed by a meta-tag re-stamp, or ensure_meta_integrity will reject the key on next load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_warningfield toKeyMetathat serializes at the top of.metaJSON files, warning users and agents not to modify these files directly since they are HMAC-verified.save_metadocumenting the meta-tag invariant: every call must be followed by a meta-tag re-stamp, orensure_meta_integritywill reject the key on next load.Context
This is a companion change to godaddy/sshenc#TBD which routes
sshenc identitythrough the agent IPC protocol. The root cause was thatset_identitycalledsave_meta()directly without re-stamping the keychain meta-tag, breaking all subsequent sign operations.Test plan
cargo test --workspace— all 1011 tests passcargo clippy --workspace --all-targets -- -D warnings— cleancargo fmt --all -- --check— clean