Skip to content

Conversation

@zhabba
Copy link
Contributor

@zhabba zhabba commented Dec 9, 2025

No description provided.

Signed-off-by: Dmitrii Puzikov <dmitrii.puzikov@gooddata.com>
@zhabba zhabba enabled auto-merge December 9, 2025 17:12
@zhabba zhabba requested a review from Copilot December 10, 2025 11:29
@zhabba zhabba merged commit 5f40c49 into master Dec 10, 2025
1 check passed
@zhabba zhabba deleted the dp-fix-close branch December 10, 2025 11:29
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses StreamClosedException issues by improving HTTP client lifecycle management and error handling. The changes focus on proper stream handling in Apache HttpClient 5, graceful handling of already-logged-out states, and enhanced test initialization to prevent resource conflicts.

Key Changes:

  • Refactored HTTP client execution to use executeOpen() for proper stream lifecycle management
  • Added graceful handling of "already logged out" errors in AccountService
  • Restructured test initialization by moving service initialization to @BeforeClass and removing test dependencies that could cause race conditions

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
HttpClient5ComponentsClientHttpRequestFactory.java Refactored HTTP request execution to use executeOpen() methods and improved stream handling to prevent StreamClosedException
AccountService.java Added logic to gracefully handle already-logged-out errors during logout operations
AbstractGoodDataAT.java Added exception handling to cleanup methods to prevent cleanup failures from cascading
WarehouseServiceAT.java Moved service initialization from constructor to @BeforeClass method and removed test group dependencies
OutputStageServiceAT.java Restructured warehouse setup as a test method and updated test dependencies
HttpClient5ComponentsClientHttpRequestFactoryTest.java Added comprehensive unit tests for HTTP client factory functionality
HttpClient5ComponentsClientHttpRequestFactoryIT.java Added integration tests with real HTTP communication scenarios
HttpClient5ComponentsClientHttpRequestFactoryAT.java Added acceptance tests for real-world usage with GoodData endpoints

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants