Skip to content

clipping: support default unitwise_norm for 5D params#1576

Merged
copybara-service[bot] merged 2 commits intogoogle-deepmind:mainfrom
scalarian:unitwise-norm-5d-default
Jan 29, 2026
Merged

clipping: support default unitwise_norm for 5D params#1576
copybara-service[bot] merged 2 commits intogoogle-deepmind:mainfrom
scalarian:unitwise-norm-5d-default

Conversation

@staticpayload
Copy link
Copy Markdown
Contributor

Summary

  • extend default unitwise_norm behavior to rank-5 tensors (Conv3D kernels)
  • update tests to cover the new default behavior

Testing

  • python3.11 -m venv .venv-test
  • pip install -e .
  • pip install pytest
  • pytest optax/transforms/_clipping_test.py -q

@vroulet
Copy link
Copy Markdown
Collaborator

vroulet commented Jan 27, 2026

Can you sync with head, update the docs and add a test?
Thanks

@staticpayload staticpayload force-pushed the unitwise-norm-5d-default branch from 2f6f74d to 611c0b4 Compare January 28, 2026 03:51
@staticpayload
Copy link
Copy Markdown
Contributor Author

Can you sync with head, update the docs and add a test? Thanks

Done

Copy link
Copy Markdown
Collaborator

@vroulet vroulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@staticpayload
Copy link
Copy Markdown
Contributor Author

🫡

@copybara-service copybara-service Bot merged commit 960aa20 into google-deepmind:main Jan 29, 2026
16 checks passed
@staticpayload staticpayload deleted the unitwise-norm-5d-default branch January 30, 2026 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants