This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Open
Conversation
Needs to set required fields as required
Collaborator
I don't think this fills both those requirements. I'll have to re-read this in more detail. |
Needs to set required fields as required Handle cases dataclasses, TypedDict and Pydantic models
Member
|
Could you also add tests to cover the cases you're fixing? This way we insure against backsliding. |
Author
Jacksonearl2468
approved these changes
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs to set required fields as required
Description of the change
When feeding a response_schema of type TypedDict to a GenerationConfig, then we need to set the field as required if it is required. This codes does that. It also avoids setting optional fields (Optional and NotRequired) as required.
Motivation
It solves the issue described in #560
Type of change
Bug fix
Checklist
git pull --rebase upstream main).