This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Fix response_schema with TypedDict#640
Closed
Surya2k1 wants to merge 1 commit intogoogle-gemini:mainfrom
Closed
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
status:awaiting review
Contributor
Author
|
I believe the PR #643 is a better fix for schema with Class and Nested class objects. I am not sure how it goes with Function calling with "required" field mentioned. But I don't see an example of how to send "required" field in case of function call tools. |
github-actions
bot
removed
the
status:awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Fix
response_schemaissue with TypedDicts.Motivation
May Fix #560 .
Type of change
Bug Fix.
There seems a proposed fix already. I tried with different approach. May be reviewed once whether it works.