Skip to content

Add GOOGLE_GENAI_USE_VERTEXAI variable setting to make workflow work #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huan wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add GOOGLE_GENAI_USE_VERTEXAI variable setting to make workflow work #387

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e7fbc5e
Add GOOGLE_GENAI_USE_VERTEXAI variable setting
huan Nov 7, 2025
b0213bb
Merge branch 'main' into patch-1
huan Nov 10, 2025
6726e82
Initial plan
Copilot Nov 10, 2025
7f13d68
Add GOOGLE_GENAI_USE_VERTEXAI to setup script for both automatic and …
Copilot Nov 10, 2025
0ac8872
Merge pull request #2 from huan/copilot/improve-if-else-branch-coverage
huan Nov 10, 2025
f0248ee
Merge branch 'google-github-actions:main' into main
huan Nov 10, 2025
35ff81d
Merge remote-tracking branch 'origin/main' into patch-1
huan Nov 10, 2025
0b193a4
Merge branch 'main' into patch-1
huan Nov 14, 2025
7540f4a
Merge branch 'main' into patch-1
huan Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/setup_workload_identity.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,7 @@ if command -v gh &> /dev/null; then
gh variable set GOOGLE_CLOUD_PROJECT --body "${GOOGLE_CLOUD_PROJECT}" --repo "${GITHUB_REPO}"
gh variable set GOOGLE_CLOUD_LOCATION --body "${GOOGLE_CLOUD_LOCATION}" --repo "${GITHUB_REPO}"
gh variable set SERVICE_ACCOUNT_EMAIL --body "${SERVICE_ACCOUNT_EMAIL}" --repo "${GITHUB_REPO}"
gh variable set GOOGLE_GENAI_USE_VERTEXAI --body "true" --repo "${GITHUB_REPO}"
Copy link

Copilot AI Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new GOOGLE_GENAI_USE_VERTEXAI variable is set automatically when gh CLI is available, but it's not included in the manual setup instructions in the else block (lines 462-477). Users without the gh CLI won't know to set this variable manually. Consider adding documentation for this variable in the else block, similar to the other variables.

Copilot uses AI. Check for mistakes.
Copy link
Author

@huan huan Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Copy link
Author

@huan huan Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved.


print_success "GitHub variables have been set automatically!"
else
Expand All @@ -474,6 +475,10 @@ else
echo "☁️ Variable Name: SERVICE_ACCOUNT_EMAIL"
echo " Variable Value: ${SERVICE_ACCOUNT_EMAIL}"
echo ""
echo "🤖 Variable Name: GOOGLE_GENAI_USE_VERTEXAI"
echo " Variable Value: true"
echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"
Copy link
Contributor

@gemini-cli gemini-cli bot Nov 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Consider clarifying how to 'use GOOGLE_GENAI_USE_GCA'. The current phrasing might imply setting GOOGLE_GENAI_USE_GCA to true, but it's not explicitly stated as it is for GOOGLE_GENAI_USE_VERTEXAI. Perhaps something like 'or set GOOGLE_GENAI_USE_GCA to 'true' for Code Assist'.

Suggested change
echo " (Set to 'true' to use Vertex AI, or use GOOGLE_GENAI_USE_GCA for Code Assist)"
echo " (Set to 'true' to use Vertex AI, or set GOOGLE_GENAI_USE_GCA to 'true' for Code Assist)"

echo ""
fi

print_success "Setup completed successfully! 🚀"