Assuring a non-zero increase of _penalty#54
Open
dchichkov wants to merge 1 commit intogoogle-research:masterfrom
Open
Assuring a non-zero increase of _penalty#54dchichkov wants to merge 1 commit intogoogle-research:masterfrom
dchichkov wants to merge 1 commit intogoogle-research:masterfrom
Conversation
Does it makes sense?
Contributor
|
Yes, this seems reasonable. Did you train an agent like this to see if it affects performance? |
Author
|
I've seen in my environment that _penalty does go to exact zero, and "increase penalty" logic doesn't increase it as a result. I haven't performed enough runs to tell, if it affects performance or not. It may as well be that it doesn't and a sensible change would be to stop wasting time on calculating KL term, once _penalty is zero! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does it makes sense?