-
Notifications
You must be signed in to change notification settings - Fork 733
docs: support i18n and add Simplified Chinese (zh-CN) translation for A2UI documentation #488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Simplified Chinese (zh-CN) translations for the documentation and configures i18n support using mkdocs-static-i18n. The changes are well-structured and effectively add localization. I've identified a few minor grammatical issues and typos in the new Chinese markdown files, along with one broken video link due to a typo in a filename. The configuration changes in mkdocs.yaml and requirements-docs.txt appear correct for enabling internationalization. Overall, this is a valuable addition that improves the accessibility of the documentation.
- Translated all documentation files in `docs/` to `docs/zh/`. - Configured `mkdocs.yaml` for i18n support with `zh` locale and localized navigation. - Updated `specification` files to reference original English sources using `!--8<--` syntax to maintain single source of truth.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Hi @jacobsimionato , |
Description
This PR adds full Simplified Chinese (zh-CN) translation support for the A2UI documentation.
Changes
docs/zh/mirroring the structure of the originaldocs/.mkdocs.yamlto enable thezhlocale usingmkdocs-static-i18nplugin and added a localized navigation bar (nav_translations).docs/zh/specification/*.md) directly reference the original English specification files (e.g., inspecification/v0_8/docs/) using the snippet inclusion syntax (--8<--). This ensures the technical specification remains a single source of truth while the wrapper content is localized.Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.