v0.9 Spec: Add identity fields to theme #498
Conversation
Changes: - Removed outputFormat from DateTimeInput as it was underspecified. - Added min and max properties to DateTimeInput for ISO 8601 range constraints. - Added openUrl function to the standard catalog for handling links. - Updated schema definitions to support 'void' return type for functions.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces identity fields (iconUrl and agentDisplayName) to the theme specification, which is a valuable addition for attribution and security in multi-agent scenarios. The changes are well-documented in a2ui_protocol.md. The PR also includes the addition of an openUrl function and updates to the DateTimeInput component. While these changes seem correct and beneficial, they are not mentioned in the PR description, which could be updated for clarity. The overall changes improve the specification. I've found one minor formatting issue in the documentation.
| | :----------------- | :----- | :-------------------------------------------------------------------------------------------------------- | | ||
| | **primaryColor** | String | The primary UI color as a hexadecimal code (e.g., '#00BFFF'). | | ||
| | **iconUrl** | URI | A URL for an image (e.g., logo or avatar) that identifies the agent or tool associated with the surface. | | ||
| | **agentDisplayName**| String | Text to be displayed next to the surface to identify the agent or tool that created it (e.g. "Weather Bot").| |
There was a problem hiding this comment.
There's a formatting issue in the markdown table. A space is missing between **agentDisplayName** and the following |, which will likely cause rendering issues for this row by merging the 'Property' and 'Type' columns.
| | **agentDisplayName**| String | Text to be displayed next to the surface to identify the agent or tool that created it (e.g. "Weather Bot").| | |
| | **agentDisplayName** | String | Text to be displayed next to the surface to identify the agent or tool that created it (e.g. "Weather Bot").| |
1 participant
This PR updates the v0.9 specification to include iconUrl and agentDisplayName in the standard catalog theme definition.
Changes