Skip to content

refactor: remove the Optional param in VertexAiCodeExecutor method #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: remove the Optional param in VertexAiCodeExecutor method #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions core/src/main/java/com/google/adk/codeexecutors/VertexAiCodeExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.Optional;
import org.jspecify.annotations.Nullable;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

Expand Down Expand Up @@ -140,7 +140,7 @@ public CodeExecutionResult executeCode(
executeCodeInterpreter(
getCodeWithImports(codeExecutionInput.code()),
codeExecutionInput.inputFiles(),
codeExecutionInput.executionId());
codeExecutionInput.executionId().orElse(null));

// Save output file as artifacts.
List<File> savedFiles = new ArrayList<>();
Expand Down Expand Up @@ -173,7 +173,7 @@ public CodeExecutionResult executeCode(
}

private Map<String, Object> executeCodeInterpreter(
String code, List<File> inputFiles, Optional<String> sessionId) {
String code, List<File> inputFiles, @Nullable String sessionId) {
ExtensionExecutionServiceClient codeInterpreterExtension = getCodeInterpreterExtension();
if (codeInterpreterExtension == null) {
logger.warn("Vertex AI Code Interpreter execution is not available. Returning empty result.");
Expand All @@ -196,8 +196,9 @@ private Map<String, Object> executeCodeInterpreter(
paramsBuilder.putFields(
"files", Value.newBuilder().setListValue(listBuilder.build()).build());
}
sessionId.ifPresent(
s -> paramsBuilder.putFields("session_id", Value.newBuilder().setStringValue(s).build()));
if (sessionId != null) {
paramsBuilder.putFields("session_id", Value.newBuilder().setStringValue(sessionId).build());
}

ExecuteExtensionRequest request =
ExecuteExtensionRequest.newBuilder()
Expand Down