Add numeric overloads for cuttlefish::Pretty.
#2032
Merged
+96
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard says that accessing unaligned values by reference is undefined behavior. These overloads of `cuttlefish::Pretty` capture calls that use numeric values and pass them by value rather than the default pass-by-reference fallback defined in `pretty.h`. This is because numeric values are likely to appear in `__attribute__((packed))` structs which can have unaligned values. google#2014 introduced pretty-printing for some packed structs which have unaligned fields and it ran into this issue trying to pass the struct fields by reference, so it was reverted in google#2025 . Bug: b/476228593
ser-io
approved these changes
Jan 20, 2026
Member
Author
|
Thanks for reviewing! |
Databean
changed the title
cuttlefish::Preetty.cuttlefish::Pretty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard says that accessing unaligned values by reference is undefined behavior. These overloads of
cuttlefish::Prettycapture calls that use numeric values and pass them by value rather than the default pass-by-reference fallback defined inpretty.h. This is because numeric values are likely to appear in__attribute__((packed))structs which can have unaligned values.#2014 introduced pretty-printing for some packed structs which have unaligned fields and it ran into this issue trying to pass the struct fields by reference, so it was reverted in #2025 .
Bug: b/476228593