Start ReadLoop thread after all members have been initialized #2036
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3405691582
approved these changes
Jan 21, 2026
jemoreira
approved these changes
Jan 21, 2026
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
Member
|
Tests are failing because of bazel 9, once #2037 merges this one should be unblocked. |
This patch prevents ReadLoop thread of using members of the class which are not initialized yet. Test: ran cvd start and verified kernel logs appear Signed-off-by: Bogdan-Cosmin Chifor <bogdan.chifor@tii.ae>
Databean
force-pushed
the
kernellog-crash-fix
branch
from
50f5a3a to
2e7193d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents ReadLoop thread of using members of the class which are not initialized yet.
Test: ran cvd start and verified kernel logs appear.
PR was already approved here: https://android-review.googlesource.com/c/device/google/cuttlefish/+/3909424