GATT: fix redefinition of GATT_CONTENT_CONTROL_ID_CHARACTERISTIC #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barbibulle
reviewed
Dec 29, 2025
Collaborator
barbibulle
left a comment
barbibulle
left a comment
There was a problem hiding this comment.
It would be better to just remove it under Media Control Service (MCS) and keep the one listed under Telephone Bearer Service (TBS). The grouping is purely arbitrary (not found in the specs), and since they are unique and defined in a single doc ("assigned numbers"), there's no need to have two names for the same UUID.
Contributor
Author
|
Oops, I missed that it was the same UUID. |
Remove the first occurrence of GATT_CONTENT_CONTROL_ID_CHARACTERISTIC. The "Telephone Bearer Service (TBS)" section also defines GATT_CONTENT_CONTROL_ID_CHARACTERISTIC later, so we don't need this one.
dlech
force-pushed
the
fix-duplicate-GATT_CONTENT_CONTROL_ID_CHARACTERISTIC
branch
from
83387fa to
9ad0eaf
Compare
Contributor
Author
|
Changed the commit to remove the duplicate. |
barbibulle
approved these changes
Dec 29, 2025
dlech
deleted the
fix-duplicate-GATT_CONTENT_CONTROL_ID_CHARACTERISTIC
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the first assignment of
GATT_CONTENT_CONTROL_ID_CHARACTERISTICwithGATT_MCS_CONTENT_CONTROL_ID_CHARACTERISTIC.The "Telephone Bearer Service (TBS)" section also defines
GATT_CONTENT_CONTROL_ID_CHARACTERISTIClater with UUID 0x2BBA, which was writing over the previous definition in the "Media Control Service (MCS)" section.