Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
I signed it! |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
PreviewImpl.Callback.onSurfaceChanged()assumes that the camera has been initialized and started properly. However, there is no check for this whenstartCaptureSession()is called byonSurfaceChanged().In particular, on first launch after install, the OS permissions dialog appears, which prevents
startCaptureSession()from starting normally (fromCamera2.start()). This invalidates the original assumption. However,startCaptureSession()is called anyways, which leads to the IllegalStateException due to the camera not being started properly.The fix is to guarantee that
startCaptureSession()is not called prematurely until the camera has been properly started.This fixes issue #11