fix: normalize paths for filePushOrder matching#1131
Conversation
Fixes an issue where `filePushOrder` fails to properly match and sort files on Windows or when paths have mixed directory separators (e.g. `\` vs `/`). By calling `path.normalize()` on both the files' `localPath` and the paths configured in `filePushOrder`, we ensure a consistent format is used for matching and ordering. Co-authored-by: sqrrrl <346343+sqrrrl@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Added a unit test to verify that `filePushOrder` correctly matches and orders files regardless of path separators, preventing regressions for the path normalization fix. Co-authored-by: sqrrrl <346343+sqrrrl@users.noreply.github.com>
1 participant
Fixes issue #1129. On Windows,
filePushOrderwas ignored if the paths in.clasp.jsonused forward slashes (/), resulting in alphabetical ordering. This PR fixes the issue by usingpath.normalize()to match the push order paths with the local file paths.PR created automatically by Jules for task 5315373055565844319 started by @sqrrrl