fix(security) : Fix race condition in file write operations (Symlink TOCTOU)#1146
Merged
Merged
Conversation
Add test coverage for symlink attack prevention and path traversal blocking in WriteFiles operations.
Contributor
Author
|
@sqrrrl please review!! |
sqrrrl
approved these changes
Apr 14, 2026
Contributor
Author
|
Hey @sqrrrl , since this fix addresses a TOCTOU vulnerability that could lead to arbitrary file writes, do you think it makes sense to track it as a security advisory or CVE? Happy to help with details or writeup if needed. |
Contributor
Author
|
also can you check #1145? I fixed the conflicts there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes(#1148)
Prevent symlink race condition attacks in WriteFiles() that could allow
arbitrary file writes outside the project directory.
Changes:
Fixes: TOCTOU vulnerability in pull/clone operations
npm run testsucceeds.npm run lintsucceeds.