Optimize Android emulator initialization by batching reboots#5280
Open
jardondiego wants to merge 10 commits into
Open
Optimize Android emulator initialization by batching reboots#5280jardondiego wants to merge 10 commits into
jardondiego wants to merge 10 commits into
Conversation
This change reduces the number of reboots during Android device setup by: - Adding a wait_for_reboot parameter to adb.write_data_to_file. - Tracking reboot status in initialize_device to skip the final reboot if one already occurred. - Disabling reboots when setting sanitizer options since the app restart is sufficient. These optimizations improve bot startup efficiency and overall fuzzing throughput.
added 6 commits
May 16, 2026 16:57
… tracking and short-circuit issues
IvanBM18
reviewed
May 18, 2026
Collaborator
There was a problem hiding this comment.
Nit:
Add typing hints and update the string doc for this method so that other devs reading this know what the bool means
IvanBM18
reviewed
May 18, 2026
| return True | ||
|
|
||
|
|
||
| def get_debug_props_and_values(): |
Collaborator
There was a problem hiding this comment.
Nit x2:
Add typing hints and update the string doc for this method so that other devs reading this know what the bool means
IvanBM18
reviewed
May 18, 2026
| sanitizer_options, sanitizer_options_file_path, wait_for_reboot=False) | ||
|
|
||
|
|
||
| def setup_asan_if_needed(): |
Collaborator
There was a problem hiding this comment.
Nit x3:
Add typing hints and update the string doc for this method so that other devs reading this know what the bool means
fernandofloresg
approved these changes
May 18, 2026
Collaborator
fernandofloresg
left a comment
fernandofloresg
left a comment
There was a problem hiding this comment.
lgtm, would be nice to add those docstrings
| return True | ||
|
|
||
|
|
||
| def get_debug_props_and_values(): |
Adds `-> bool` return type hints and explanatory docstrings to: - `configure_system_build_properties` - `setup_asan_if_needed` These updates clarify that the returned boolean indicates whether a device reboot occurred during the setup step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the number of reboots during Android device setup by:
These optimizations improve bot startup efficiency and overall fuzzing throughput.