DuplicateAssertion: detect duplicated assertion lines where the argument to assertThat is pure.
#5324
+247
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_821773490
branch
from
9f4c231 to
eeb92b1
Compare
copybara-service
bot
force-pushed
the
test_821773490
branch
from
eeb92b1 to
3398380
Compare
…ent to `assertThat` is pure. This just looks for successive assertion statements with the same source code, and uses our friend `ConstantExpressions` to check whether the argument to `assertThat` seems pure at heart. Flume: unknown commit PiperOrigin-RevId: 848124748
copybara-service
bot
force-pushed
the
test_821773490
branch
from
3398380 to
3f40f17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuplicateAssertion: detect duplicated assertion lines where the argument to
assertThatis pure.This just looks for successive assertion statements with the same source code, and uses our friend
ConstantExpressionsto check whether the argument toassertThatseems pure at heart.Flume: unknown commit