-
Notifications
You must be signed in to change notification settings - Fork 100
Dynamic search of ek keys with ekCertificates #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This patch allows ek keys to be searched in additional persistent key handle locations. And to return the actual Certificate and handle mapping when the keys in the handles do not match the default values. Unifies creation of EK and allows listing of high certs if present. Rationale: During the deployment of some newer lenovo systems the default rsa handle comes with a 3k key which prevents attestation from working as built. Thus the need for the library to create the 2k key in a separate location in case the default location is already occupied and there is no 2k on the standard locations.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
liamjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some tests of this, using the setupSimulatedTPM() as a starting point?
Mostly used internal interfaces as simulator does not have an EkCert in nvram location.
liamjm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just some small nits, otherwise LGTM.
|
It would be helpful to describe why the 3K certificate attestation fails - that's not made explicit in the description, but would help justify the modifications. |
|
@mjg59 I added some of the issues found around 3k certs in the description. In short:
I have been able to do self attestation test against with p256 and rsa2048 AK endordorsed by p256 or rsa2048 ek. |
This patch allows ek keys to be searched in additional persistent key handle locations. And to return the actual Certificate and handle mapping when the keys in the handles do not match the default values.
Unifies creation of EK and allows listing of high certs if present.
Rationale:
During the deployment of some newer lenovo systems the default rsa handle comes with a 3k key which prevents attestation from working as built. Thus the need for the library to create the 2k key in a separate location in case the default location is already occupied and there is no 2k on the standard locations.
Today, there is no support for RSA 3k on the codebase. Among other things there is need for adding the 3k storage EK handles, and their templates. Initial exploration with these returned a bad policy error. 3k issues should be resolved in a different PR