update cpp-jsonnet to (unreleased) 833f18402b6b#860
Merged
johnbartholomew merged 2 commits intogoogle:masterfrom Mar 8, 2026
Merged
update cpp-jsonnet to (unreleased) 833f18402b6b#860johnbartholomew merged 2 commits intogoogle:masterfrom
johnbartholomew merged 2 commits intogoogle:masterfrom
Conversation
Collaborator
Author
|
Has at least one problem: #861 |
johnbartholomew
force-pushed
the
update-cpp-jsonnet
branch
from
72b2e78 to
e2eb1e3
Compare
This doesn't make them fully correct, in particular directives sections (e.g., "%YAML 1.2" directive before a document start marker) are not handled correctly, but they weren't handled correctly before, either. It also doesn't recognise or try to do anything about document end markers (`...`). This fix does allow scalar documents to be on the same line as the document start tag which is valid per examples in the YAML spec, see for example https://yaml.org/spec/1.2.1/#id2760844 (YAML 1.2.1 spec, section 2.3 Scalars) It also matches the C++ jsonnet output for std.parseYaml("42\n---"), which is a stream of two documents, a scalar and then an empty document (where the empty document is interpreted as JSON null)
johnbartholomew
force-pushed
the
update-cpp-jsonnet
branch
from
e2eb1e3 to
509404f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.