Print names of unclean files in jsonnetfmt --test and --in-place#863
Merged
johnbartholomew merged 2 commits intogoogle:masterfrom Mar 8, 2026
Merged
Print names of unclean files in jsonnetfmt --test and --in-place#863johnbartholomew merged 2 commits intogoogle:masterfrom
johnbartholomew merged 2 commits intogoogle:masterfrom
Conversation
…-place Fixes google#768 Also the go-jsonnet version of google/jsonnet#365
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go port of google/jsonnet#1303
Also updates cpp-jsonnet submodule to get the updates to test_cmd (which is test coverage for jsonnetfmt CLI)
It should print names of changed files (for
--in-placemode) or files which are not correctly formatted (for--testmode). Inputs which come from stdin (input name-on the command line), or which have no name (using the-eflag) should not cause any name to be printed regardless of whether they are cleanly formatted or not, but the jsonnetfmt--testexit code should still reflect whether the input was cleanly formatted.