Skip to content

Conversation

@shobhitagarwal1612
Copy link
Member

@shobhitagarwal1612 shobhitagarwal1612 commented Jan 18, 2026

Towards #1795

This PR aims to shift all non-Android logic, including screen generation, over to Jetpack Compose. This change is a step towards enabling Kotlin Multiplatform (KMP) support (as detailed in issue #3416) by removing the reliance on UI Views for iOS. While the long-term plan is to replace Fragments with Jetpack Navigation Compose, this specific PR focuses solely on the logic migration to Compose. The full switch to Navigation Compose will occur in a single update once every screen has been successfully migrated.

Verified that the functionality doesn't change by running the app locally. Also added test coverage for newly added compose screen and view models.

We've replaced the native progress dialog with a Jetpack Compose version, resulting in a slight visual change. Other screens will be updated to use this new dialog over time for consistency.

@andreia-ferreira @gino-m PTAL?

This will be used in StartupFragment for showing progress dialog using compose
- Move startup initialization logic from `StartupFragment` to a new `StartupScreen` Composable.
- Migrate error handling and progress dialog management from `StartupFragment` to `StartupViewModel` and `StartupScreen`.
- Update `StartupViewModel` and `SignInViewModel` to use `@HiltViewModel` and remove manual bindings in `ViewModelModule`.
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.07%. Comparing base (6a168c3) to head (cf8565b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...groundplatform/android/ui/startup/StartupScreen.kt 63.63% 2 Missing and 2 partials ⚠️
...undplatform/android/ui/components/LoadingDialog.kt 89.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3461      +/-   ##
============================================
+ Coverage     70.02%   70.07%   +0.04%     
- Complexity     1608     1613       +5     
============================================
  Files           320      322       +2     
  Lines          8598     8634      +36     
  Branches        946      951       +5     
============================================
+ Hits           6021     6050      +29     
- Misses         2003     2007       +4     
- Partials        574      577       +3     
Files with missing lines Coverage Δ
...undplatform/android/ui/startup/StartupViewModel.kt 100.00% <100.00%> (ø)
...n/java/org/groundplatform/android/ui/theme/Size.kt 100.00% <100.00%> (ø)
...undplatform/android/ui/components/LoadingDialog.kt 89.47% <89.47%> (ø)
...groundplatform/android/ui/startup/StartupScreen.kt 63.63% <63.63%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The change removes an unnecessary `LaunchedEffect` wrapper around the `onLoadFailed` callback when the `StartupScreen` is in an error state.
@shobhitagarwal1612 shobhitagarwal1612 marked this pull request as ready for review January 18, 2026 16:18
@auto-assign auto-assign bot requested a review from anandwana001 January 18, 2026 16:18
@shobhitagarwal1612 shobhitagarwal1612 requested review from andreia-ferreira and removed request for anandwana001 January 18, 2026 16:18
@shobhitagarwal1612 shobhitagarwal1612 merged commit cfc4501 into master Jan 19, 2026
7 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the compose-startupfragment branch January 19, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants