Implement QR code scanner to join surveys#3711
Open
andreia-ferreira wants to merge 12 commits intomasterfrom
Open
Implement QR code scanner to join surveys#3711andreia-ferreira wants to merge 12 commits intomasterfrom
andreia-ferreira wants to merge 12 commits intomasterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3711 +/- ##
============================================
+ Coverage 68.02% 68.06% +0.04%
- Complexity 1582 1592 +10
============================================
Files 362 365 +3
Lines 9284 9366 +82
Branches 1199 1207 +8
============================================
+ Hits 6315 6375 +60
- Misses 2313 2329 +16
- Partials 656 662 +6
🚀 New features to boost your workflow:
|
Member
|
Should this show a confirmation dialog with survey details before activating the survey? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3639
This PR introduces a QR code reader in the survey selector screen so the user can join unlisted surveys more easily:
MicrosoftTeams-video.mp4
ML Kit was used even though technically we could re-use the ZXing library for reading QR codes. However, that would require a custom implementation, while ML Kit ships its own scanner UI as a Play Services module, so we don't have to build/maintain a camera Activity or handle camera permissions ourselves at runtime
The error handling in the survey selector was polished: errors from survey listing, activation, and QR scanning now route through a single
ShowErrorwith aErrorTypewith the different variants, mapped consistently in the fragment to the right popup string@shobhitagarwal1612 PTAL?