Replace legacy apply plugin usage#3721
Merged
shobhitagarwal1612 merged 1 commit intomasterfrom May 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3721 +/- ##
=========================================
Coverage 67.95% 67.95%
Complexity 1571 1571
=========================================
Files 365 365
Lines 9366 9366
Branches 1218 1218
=========================================
Hits 6365 6365
Misses 2333 2333
Partials 668 668 🚀 New features to boost your workflow:
|
shobhitagarwal1612
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates module plugin declarations from the legacy
apply pluginsyntax to the modernplugins {}block using version catalog aliases. This fixes issues where updating gradle plugin, builds started failing during manifest merging : #3720 and #3708The issue appears to be related to plugin evaluation order: with the legacy plugin style, the secrets gradle plugin was not being applied early enough, so manifest placeholders were not populated in time which caused manifest merge failures. According to the official docs, wiith the new approach, the plugin resolution happens earlier which ensures the secrets plugin is available before manifest processing.
@shobhitagarwal1612 PTAL?