Skip to content

Replace legacy apply plugin usage#3721

Merged
shobhitagarwal1612 merged 1 commit intomasterfrom
andreia/fix-gradle-secrets-issue
May 6, 2026
Merged

Replace legacy apply plugin usage#3721
shobhitagarwal1612 merged 1 commit intomasterfrom
andreia/fix-gradle-secrets-issue

Conversation

@andreia-ferreira
Copy link
Copy Markdown
Collaborator

This PR migrates module plugin declarations from the legacy apply plugin syntax to the modern plugins {} block using version catalog aliases. This fixes issues where updating gradle plugin, builds started failing during manifest merging : #3720 and #3708

The issue appears to be related to plugin evaluation order: with the legacy plugin style, the secrets gradle plugin was not being applied early enough, so manifest placeholders were not populated in time which caused manifest merge failures. According to the official docs, wiith the new approach, the plugin resolution happens earlier which ensures the secrets plugin is available before manifest processing.

@shobhitagarwal1612 PTAL?

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.95%. Comparing base (ca1ddd2) to head (159b67e).

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3721   +/-   ##
=========================================
  Coverage     67.95%   67.95%           
  Complexity     1571     1571           
=========================================
  Files           365      365           
  Lines          9366     9366           
  Branches       1218     1218           
=========================================
  Hits           6365     6365           
  Misses         2333     2333           
  Partials        668      668           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shobhitagarwal1612 shobhitagarwal1612 merged commit 2083bbf into master May 6, 2026
13 checks passed
@shobhitagarwal1612 shobhitagarwal1612 deleted the andreia/fix-gradle-secrets-issue branch May 6, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants