Fix language switch delay on release builds#3731
Open
andreia-ferreira wants to merge 1 commit into
Open
Conversation
andreia-ferreira
temporarily deployed
to
e2e-approval
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3731 +/- ##
=========================================
Coverage 68.06% 68.06%
Complexity 1609 1609
=========================================
Files 370 370
Lines 9513 9513
Branches 1238 1238
=========================================
Hits 6475 6475
Misses 2360 2360
Partials 678 678 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3730
In release builds (AAB via Play Store), language config splits are only delivered at install time for locales matching the device's system languages. Other languages are fetched on demand the first time they're requested. This can cause a delay and requires internet access when changing the language.
This PR disables per-language bundle splits so all translated string resources ship in the release aab. Install-size cost is negligible since the app only localizes string resources.
@shobhitagarwal1612 PTAL?