Rotom Rolled Layouts#2913
Open
edwjchen wants to merge 1 commit into
Open
Conversation
Collaborator
edwjchen
commented
May 1, 2026
edwjchen
commented
- Added optional rolls metadata to LayoutAttr in RotomAttributes.td and verifier checks in RotomAttributes.cpp.
- Added/updated rolled layout lowering unit tests in RotomTensorExtLayoutLoweringTest.cpp.
- Preserved user-specified traversal dim order in layout preprocessing (removed canonical traversal reorder/remap).
asraa
reviewed
May 13, 2026
asraa
approved these changes
May 21, 2026
Collaborator
|
could you give a quick rebase to resolve the merge conflicts? |
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.