add addition kernels#110
Open
copybara-service[bot] wants to merge 1 commit into
Open
Conversation
copybara-service
Bot
force-pushed
the
test_916999865
branch
3 times, most recently
from
f2961e8 to
c65dc2e
Compare
It is worth noting that cross uses three distinct addition kernels: one when no reduction is needed (and this is guaranteed), one when barrett reduction is needed, and one when a simpler subtraction-based reduction can be used because the sum is known to exceed the modulus, but not to overflow the underlying data type. PiperOrigin-RevId: 916999865
copybara-service
Bot
force-pushed
the
test_916999865
branch
from
c65dc2e to
21658cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add addition kernels
It is worth noting that cross uses three distinct addition kernels: one when no reduction is needed (and this is guaranteed), one when barrett reduction is needed, and one when a simpler subtraction-based reduction can be used because the sum is known to exceed the modulus, but not to overflow the underlying data type.