Don't allow underscores in TLD ROID suffixes #2913
Merged
+26
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CydeWeys
force-pushed
the
no-underscores-roid-suffixes
branch
4 times, most recently
from
2e68745 to
f2d876f
Compare
Per ICANN it's a disallowed character.
CydeWeys
force-pushed
the
no-underscores-roid-suffixes
branch
from
f2d876f to
4ee0f5d
Compare
gbrodman
approved these changes
Dec 26, 2025
Collaborator
gbrodman
left a comment
gbrodman
left a comment
There was a problem hiding this comment.
@gbrodman reviewed 8 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @CydeWeys).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per ICANN it's a disallowed character.
This change is