Skip to content

Conversation

@CydeWeys
Copy link
Member

@CydeWeys CydeWeys commented Dec 24, 2025

This was added in #2884 , but now as of this PR it can actually be configured and used on a TLD.


This change is Reviewable

@CydeWeys CydeWeys requested a review from weiminyu December 24, 2025 04:06
Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 7 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @CydeWeys).

Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @CydeWeys).


core/src/test/resources/google/registry/beam/rde/reducer_rde.xml line 42 at r1 (raw file):

    <rdeHeader:count uri="urn:ietf:params:xml:ns:rdeIDN-1.0">4</rdeHeader:count>
</rdeHeader:header>

Looks like this file needs more changes.

RdePipelineTest is still failing.

This was added in google#2884 , but now as of
this PR it can actually be configured and used on a TLD.
Copy link
Member Author

@CydeWeys CydeWeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CydeWeys made 1 comment.
Reviewable status: 6 of 8 files reviewed, 1 unresolved discussion (waiting on @weiminyu).


core/src/test/resources/google/registry/beam/rde/reducer_rde.xml line 42 at r1 (raw file):

Previously, weiminyu (Weimin Yu) wrote…

Looks like this file needs more changes.

RdePipelineTest is still failing.

PTAL, fixed.

@CydeWeys CydeWeys enabled auto-merge December 26, 2025 23:55
Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiminyu reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @CydeWeys).

Copy link
Collaborator

@weiminyu weiminyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@weiminyu made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @CydeWeys).

@CydeWeys CydeWeys added this pull request to the merge queue Dec 27, 2025
Merged via the queue into google:master with commit 6f0bc1d Dec 27, 2025
9 of 10 checks passed
@CydeWeys CydeWeys deleted the augmented_latin branch December 27, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants