Skip to content

Conversation

@chait-slim
Copy link

@chait-slim chait-slim commented Nov 25, 2025

Relevant tickets for reference:
#4396 (comment)
#3937

@google-cla
Copy link

google-cla bot commented Nov 25, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These source and source_test.yaml should be done in separate PRs, as they are imported immediately after being merged.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. The other PR: #4548

These will be added in a separate PR after the code changes are merged.
@chait-slim chait-slim mentioned this pull request Dec 23, 2025
Copy link
Contributor

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@another-rex
Copy link
Contributor

/gcbrun

@another-rex
Copy link
Contributor

Please have a look at the linting errors. (You can run this locally with make lint)

@another-rex
Copy link
Contributor

Also, tests seem to be failing:

OK
+ poetry run python -m unittest osv.purl_helpers_test
.F
======================================================================
FAIL: tests_package_to_purl (osv.purl_helpers_test.PurlHelpersTest.tests_package_to_purl)
Test PURL generation.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/workspace/osv/purl_helpers_test.py", line 140, in tests_package_to_purl
    self.assertEqual('pkg:generic/root/%40root%2Flodash',
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                     purl_helpers.package_to_purl('Root', '@root/lodash'))
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'pkg:generic/root/%40root%2Flodash' != 'pkg:generic/root/%40root/lodash'
- pkg:generic/root/%40root%2Flodash
?                         ^^^
+ pkg:generic/root/%40root/lodash
?                         ^

you can run it locally with the poetry run python -m unittest osv.purl_helpers_test , or with make all-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants