-
Notifications
You must be signed in to change notification settings - Fork 268
Root data source #4397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Root data source #4397
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These source and source_test.yaml should be done in separate PRs, as they are imported immediately after being merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. The other PR: #4548
These will be added in a separate PR after the code changes are merged.
another-rex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
/gcbrun |
|
Please have a look at the linting errors. (You can run this locally with make lint) |
|
Also, tests seem to be failing: you can run it locally with the poetry run python -m unittest osv.purl_helpers_test , or with make all-tests |
Relevant tickets for reference:
#4396 (comment)
#3937