fix: skip uploading unchanged files in exporter, compare CRC32C hash before upload #4547
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@another-rex Would really appreciate a review on this PR when you get a chance! 🙂 |
another-rex
approved these changes
Dec 28, 2025
Contributor
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
LGTM! Though we have mostly moved to a go version of the exporter, though this looks fine to merge in as well.
| import zipfile | ||
| from typing import List | ||
|
|
||
| import google_crc32c |
Contributor
There was a problem hiding this comment.
Is this already part of the dependencies? I think this should be added to pyproject.toml as a dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3513
Summary
Skip uploading files when content hasn't changed by comparing CRC32C hashes.
Changes
How it works