fix(vulnfeeds): add more phrases for extracting versions #4550
+76
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #249
This PR extends the version extraction regex in ExtractVersionsFromText to support additional common phrases found in CVE descriptions.
Details
Problem
The existing regex only matched
throughandbeforekeywords, causing version information to be lost when CVE descriptions used other common phrasing.Solution
Added support for the following phrases:
up to and including(e.g., "versions 1.0 up to and including 2.3.4")prior to(e.g., "versions prior to 2.3.4")below(e.g., "versions below 2.3.4")and earlier(e.g., "version 2.3.4 and earlier")or older(e.g., "version 2.3.4 or older")and below(e.g., "version 2.3.4 and below")The implementation uses two regex patterns:
Testing
go test -run TestExtractVersionInfo)go fmt ./...)go vet ./...)