refactor(linter): rewrite linter cronjob in go#5104
Open
jess-lowe wants to merge 10 commits intogoogle:masterfrom
Open
refactor(linter): rewrite linter cronjob in go#5104jess-lowe wants to merge 10 commits intogoogle:masterfrom
jess-lowe wants to merge 10 commits intogoogle:masterfrom
Conversation
jess-lowe
commented
Apr 24, 2026
Member
michaelkedar
left a comment
michaelkedar
left a comment
There was a problem hiding this comment.
I think this is good, just a couple of things
Member
There was a problem hiding this comment.
Maybe move this file to go/cmd/osv-linter-worker (and make sure all the paths here & in build-and-stage still work)
|
|
||
| func run() error { | ||
| ctx := context.Background() | ||
| dsClient, err := datastore.NewClient(ctx, gcpProject) |
Member
There was a problem hiding this comment.
Can we abstract away the Datastore stuff behind an interface like the importer does so this is easier to migrate in the future.
We have a SourceRepositoryStore already that is probably already sufficient for this, and you could make an ImportFindingsStore + struct that has the methods/fields you need
Member
There was a problem hiding this comment.
Maybe the ImportFindingsStore could also do the GCS bucket things too? Or are the bucket outputs unlikely to be migrated?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linter cronjob is currently timing out and not completing due to some error. Instead of fixing that, I'll take the opportunity to rewrite the linter in Go instead.