Hardening: Implement nesting depth limits and systematic overflow pro…#623
Open
uwezkhan wants to merge 1 commit intogoogle:mainfrom
Open
Hardening: Implement nesting depth limits and systematic overflow pro…#623uwezkhan wants to merge 1 commit intogoogle:mainfrom
uwezkhan wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few safety improvements to RE2 to better handle untrusted regex input.
Introduces a nesting depth limit (default 1000) to avoid extremely deep expressions that could cause memory or processing issues.
Adds a clear error (kRegexpNestedTooDeep) so users know when a regex is too deeply nested.
Fixes potential integer overflow in string handling and strengthens PODArray to prevent invalid memory allocations.
Confirms that key parts like destruction and simplification are already safe from stack overflows.
Overall, these changes make RE2 more robust against edge cases and malicious inputs.