Fix incorrect buffer size calculation in FromBytes to prevent data tr…#630
Open
uwezkhan wants to merge 1 commit intogoogle:mainfrom
Open
Fix incorrect buffer size calculation in FromBytes to prevent data tr…#630uwezkhan wants to merge 1 commit intogoogle:mainfrom
uwezkhan wants to merge 1 commit intogoogle:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an incorrect buffer size calculation in the FromBytes helper function used to convert Python buffers into absl::string_view.
Previously, the code used the number of elements (bytes.size) as the total byte length, which is incorrect for buffers where itemsize is greater than 1. This could lead to truncated data and incorrect regex behavior.
The fix ensures the correct byte length is computed using bytes.size * bytes.itemsize.
Patch / Diff