Device Property Decorators

[youneedgreg]

Fixes #135

1. Added @Property decorators to methods requested in SmartDevice.
2. Updated all code and test references to use attribute access (e.g., device.device_id instead of device.device_id()).
3. Searched and replaced all usages across the codebase, including:

• simulator.py
• simulator_building.py
• simulator_flexible_floor_plan.py

All relevant test files
Note: No changes were made for device_filepath as it was not found in the codebase.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[s2t2]

Hi @youneedgreg thanks for the PR! this looks generally good.

I just have two minor questions about formatting.

[s2t2]

I'm curious, were these indentation changes made by the auto-formatter during pre-commit hooks? Or are these indentation changes made manually?

Can you please confirm if you have installed pre-commit hooks?
https://google.github.io/sbsim/contributing/#pre-commit-hooks

If our auto-formatter is responsible, we will want to update it (in a separate issue / PR) to use a hanging indentation of four spaces (to match Google internal style rules).

[youneedgreg]

The indentation changes were made manually as pre-commit hooks were not installed locally. I've confirmed the code uses 4-space hanging indentation, which aligns with the Google style guide.

[s2t2]

OK, I saw those manual indentation changes were still in place, so I just restored the hanging indentation to use four spaces.

[s2t2]

@youneedgreg thanks for your reply, and for making those updates. I saw the device_type method is still lacking a property decorator, so if you could please implement that, then this PR will be ready for merge!