Skip to content

TLS error details remove duplicate #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hitnik merged 3 commits into from
Mar 6, 2026
Merged

TLS error details remove duplicate #1459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
442acb3
remove duplicated message
hitnik Mar 4, 2026
6a9a53f
unit tests
hitnik Mar 4, 2026
f9dc7c9
Merge branch 'dev' into fix/tls_error_details
sofyakurilova Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modules/test/tls/python/src/tls_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,6 @@ def _security_tls_v1_2_server(self):
else:
LOGGER.error('Could not resolve device IP address. Skipping')
description = 'Could not resolve device IP address'
details.append('Could not resolve device IP address.')
return 'Error', description, details

def _security_tls_v1_3_server(self):
Expand Down
2 changes: 1 addition & 1 deletion testing/unit/tls/tls_module_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ def security_tls_v1_2_server_no_ip_test(self):

self.assertEqual(result, 'Error')
self.assertEqual(description, 'Could not resolve device IP address')
self.assertEqual(details, ['Could not resolve device IP address.'])
self.assertEqual(details, [])

def security_tls_v1_2_server_no_scan_results_test(self):
"""Tests _security_tls_v1_2_server when scan finds no HTTP/HTTPS ports"""
Expand Down
Loading