feat: add IsZero method to UUID, UUIDs, NullUUID#188
Open
osamingo wants to merge 4 commits intogoogle:masterfrom
Open
feat: add IsZero method to UUID, UUIDs, NullUUID#188osamingo wants to merge 4 commits intogoogle:masterfrom
osamingo wants to merge 4 commits intogoogle:masterfrom
Conversation
|
@noahdietz I see you contributed to this repo. Do you know who could review this PR? |
|
Another PR for this feature: #167. |
Collaborator
Hello hello @bgrant0607 , we (@quartzmo and I) will look into this ! |
|
Hello hello. Thanks much @noahdietz |
Author
|
@noahdietz @quartzmo Hi, I have a request regarding for code review of this PR. In order to comply with new Go specs, we'd greatly appreciate it if you could proceed with this code review. Please, if possible would be greatly appreciated. thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing
IsZero() boolmethod would also support theomitzerooption for JSON marshalling to omit zero UUID.