chore: ignore python build artifacts for library_generation tool#13258
Open
zhumin8 wants to merge 1 commit into
Open
chore: ignore python build artifacts for library_generation tool#13258zhumin8 wants to merge 1 commit into
zhumin8 wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the .gitignore file to exclude Python build artifacts for the library_generation tool. Feedback suggests expanding the ignore list to include dist/ and *.egg-info/ directories to ensure comprehensive coverage of standard Python packaging artifacts.
Comment on lines
+90
to
+91
| # Python build artifacts for library_generation tool | ||
| sdk-platform-java/hermetic_build/library_generation/build/ |
Contributor
There was a problem hiding this comment.
The PR aims to ignore Python build artifacts, but currently only specifies the build/ directory. Standard Python packaging tools (such as setuptools) also typically generate dist/ and *.egg-info/ directories during the build process. Including these will provide more comprehensive coverage and prevent accidental commits of these artifacts, consistent with the PR's objective.
# Python build artifacts for library_generation tool
sdk-platform-java/hermetic_build/library_generation/build/
sdk-platform-java/hermetic_build/library_generation/dist/
sdk-platform-java/hermetic_build/library_generation/*.egg-info/
suztomo
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ignore python build artifacts for library_generation tool