-
Notifications
You must be signed in to change notification settings - Fork 1.6k
test: Add 'cryptography' 'cachetools' to test deps for bigquery-storage #14999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ery-storage Fixes test failures such as https://btx.cloud.google.com/invocations/046f57c8-7637-4cc8-9cf3-02a45fb1b063
Summary of ChangesHello @Linchin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the stability of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds 'cryptography' to the SYSTEM_TEST_EXTRAS list in noxfile.py to include it as a dependency for system tests. There are no review comments provided for this change.
|
LGTM, sorta. #QUESTION The link to a traceback that you shared takes us to a prerelease test. What changed so that all of a sudden this test environment changed? It seems that this should have been a problem the whole time. |
chalmerlowe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, see my question in a separate comment.
I think the indirect dependencies are installed via this line:
So the |
Fixes test failures such as https://btx.cloud.google.com/invocations/046f57c8-7637-4cc8-9cf3-02a45fb1b063
It seems to have been caused by the recent changes in auth:
googleapis/google-auth-library-python#1919
googleapis/google-auth-library-python#1590
Example error log: