chore(nox): chore update noxfile with format session that uses ruff#16647
Draft
chalmerlowe wants to merge 4 commits intomainfrom
Draft
chore(nox): chore update noxfile with format session that uses ruff#16647chalmerlowe wants to merge 4 commits intomainfrom
chalmerlowe wants to merge 4 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request replaces isort and black with ruff for code formatting and import sorting across multiple packages. The review identifies several issues, including missing tool installations, missing session implementations, and the use of undefined variables. It also recommends removing redundant formatting sessions, restoring type hints, and refactoring duplicated path lists to improve maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
Unit test failures are in sqlalchemy-spanner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #16014
Provides the following update to multiple noxfiles:
formatnox session to use ruff for formattingWhat it does NOT do:
This is not a universal panacea... it is purposefully kept lean and focuses on a single task.
It does not delete black versions, it does not delete isort versions, etc.