-
Notifications
You must be signed in to change notification settings - Fork 100
impl(pubsub): introduce Session
#4177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4177 +/- ##
==========================================
+ Coverage 94.74% 94.76% +0.02%
==========================================
Files 186 187 +1
Lines 7035 7068 +33
==========================================
+ Hits 6665 6698 +33
Misses 370 370 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PTAL
Part of the work for #3957
Introduce a
Session, which will be a public-facing type. Applications interact with this to stream messages.The streamed item is a
Result<(Message, Handler)>. Applications are forced to handle stream errors, if any.As of 2026-01-06, this is not reflected in go/cloud-rust:subscriber-api. I need to do an update on that thing. I want to get something, anything working first.
I tried to keep this PR minimal. That means it is missing things like:
I have plans for 1-3. I am sure 4-6 can be done.