Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Jan 7, 2026

Part of the work for #3957

Introduce a Session, which will be a public-facing type. Applications interact with this to stream messages.

The streamed item is a Result<(Message, Handler)>. Applications are forced to handle stream errors, if any.

As of 2026-01-06, this is not reflected in go/cloud-rust:subscriber-api. I need to do an update on that thing. I want to get something, anything working first.

I tried to keep this PR minimal. That means it is missing things like:

  1. keepalives
  2. lease management
  3. graceful shutdown
  4. stream retries
  5. exactly once messages
  6. etc.

I have plans for 1-3. I am sure 4-6 can be done.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.76%. Comparing base (5be1cb5) to head (3fecf55).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/pubsub/src/subscriber/session.rs 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
+ Coverage   94.74%   94.76%   +0.02%     
==========================================
  Files         186      187       +1     
  Lines        7035     7068      +33     
==========================================
+ Hits         6665     6698      +33     
  Misses        370      370              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review January 7, 2026 15:02
@dbolduc dbolduc requested a review from a team as a code owner January 7, 2026 15:02
suzmue
suzmue previously approved these changes Jan 8, 2026
Copy link
Member Author

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

@dbolduc dbolduc merged commit 0632ccc into googleapis:main Jan 8, 2026
30 checks passed
@dbolduc dbolduc deleted the impl-pubsub-session-pr-1 branch January 8, 2026 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants