feat(spanner): return commit response and stats#5522
Open
olavloite wants to merge 3 commits intogoogleapis:mainfrom
Open
feat(spanner): return commit response and stats#5522olavloite wants to merge 3 commits intogoogleapis:mainfrom
olavloite wants to merge 3 commits intogoogleapis:mainfrom
Conversation
- The TransactionRunner did not return the CommitResponse. This made it impossible for an application to inspect the commit timestamp. - There was no option for returning commit stats. These are only included in the CommitResponse when explicitly requested. Both of the above is added in this change. The change in return type for TransactionRunner is a breaking change, but that is OK, as we have not yet released this client.
olavloite
force-pushed
the
spanner-commit-response-and-stats
branch
from
69fce17 to
4813acd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5522 +/- ##
========================================
Coverage 97.76% 97.77%
========================================
Files 221 221
Lines 51115 51280 +165
========================================
+ Hits 49973 50138 +165
Misses 1142 1142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both of the above is added in this change.
The change in return type for TransactionRunner is a breaking change, but that is OK, as we have not yet released this client.