Skip to content

feat(auth): make GDCH authentication pub#5614

Merged
alvarowolfx merged 18 commits intogoogleapis:mainfrom
alvarowolfx:feat-auth-gdch
May 7, 2026
Merged

feat(auth): make GDCH authentication pub#5614
alvarowolfx merged 18 commits intogoogleapis:mainfrom
alvarowolfx:feat-auth-gdch

Conversation

@alvarowolfx
Copy link
Copy Markdown
Contributor

Towards #5584

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request promotes the Google Distributed Cloud (GDC) authentication feature from internal to public by renaming the "__gdch" feature to "gdch" and exposing the "gdch" module and its "Builder". The changes include extensive documentation, usage examples, and explicit error handling that directs users to the "gdch::Builder" when GDC service accounts are detected in general credential flows. Integration tests have been added to verify these new public APIs and error paths. I have no feedback to provide.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 7, 2026

Codecov Report

❌ Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.76%. Comparing base (ac4115f) to head (bea3f66).

Files with missing lines Patch % Lines
src/auth/src/credentials.rs 16.66% 5 Missing ⚠️
src/auth/src/credentials/idtoken.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5614      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files         221      221              
  Lines       51107    51115       +8     
==========================================
+ Hits        49969    49972       +3     
- Misses       1138     1143       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alvarowolfx
Copy link
Copy Markdown
Contributor Author

cc @howardjohn this PR makes the gdch authentication available/public. It will be under the gdch feature.

@alvarowolfx alvarowolfx marked this pull request as ready for review May 7, 2026 18:16
@alvarowolfx alvarowolfx requested review from a team as code owners May 7, 2026 18:16
Comment thread src/auth/Cargo.toml
@howardjohn
Copy link
Copy Markdown
Contributor

I tested this on my environment and it works as expected. thanks!

Comment thread src/auth/src/credentials.rs
@alvarowolfx alvarowolfx merged commit 5805811 into googleapis:main May 7, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants