feat(auth): make GDCH authentication pub#5614
Conversation
There was a problem hiding this comment.
Code Review
This pull request promotes the Google Distributed Cloud (GDC) authentication feature from internal to public by renaming the "__gdch" feature to "gdch" and exposing the "gdch" module and its "Builder". The changes include extensive documentation, usage examples, and explicit error handling that directs users to the "gdch::Builder" when GDC service accounts are detected in general credential flows. Integration tests have been added to verify these new public APIs and error paths. I have no feedback to provide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5614 +/- ##
==========================================
- Coverage 97.77% 97.76% -0.01%
==========================================
Files 221 221
Lines 51107 51115 +8
==========================================
+ Hits 49969 49972 +3
- Misses 1138 1143 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
cc @howardjohn this PR makes the gdch authentication available/public. It will be under the |
|
I tested this on my environment and it works as expected. thanks! |
Towards #5584