Skip to content

cleanup(pubsub): tighten visibility of internal dispatcher components#5633

Open
suzmue wants to merge 1 commit intogoogleapis:mainfrom
suzmue:allowdeadcode
Open

cleanup(pubsub): tighten visibility of internal dispatcher components#5633
suzmue wants to merge 1 commit intogoogleapis:mainfrom
suzmue:allowdeadcode

Conversation

@suzmue
Copy link
Copy Markdown
Contributor

@suzmue suzmue commented May 8, 2026

Tighten visibility from pub(crate) to private for internal actor components and helper functions that are exclusively used within publisher/actor.rs and subscriber/handler.rs.

Tighten visibility from `pub(crate)` to private for internal actor components and helper functions that are exclusively used within `publisher/actor.rs` and `subscriber/handler.rs`.

This improves code hygiene by minimizing internal API surface area.
@suzmue suzmue requested a review from a team as a code owner May 8, 2026 18:54
@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label May 8, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restricts the visibility of several internal components within the pubsub crate by changing pub(crate) modifiers to private. These changes affect the publisher's actor implementations and the subscriber's acknowledgement handling logic. I have no feedback to provide.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.76%. Comparing base (ac2237e) to head (15a9498).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5633      +/-   ##
==========================================
- Coverage   97.76%   97.76%   -0.01%     
==========================================
  Files         220      220              
  Lines       50961    50957       -4     
==========================================
- Hits        49823    49819       -4     
  Misses       1138     1138              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants