chore(deps): update dependency protobuf to v6.33.5 [security]#836
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf dependency to version 6.33.5 to patch a security vulnerability (CVE-2026-0994). The changes in requirements.txt correctly update the version and associated hashes. A review comment has been added to suggest a more robust way of managing this transitive dependency pin to improve long-term maintainability.
Note: Security Review has been skipped due to the limited scope of the PR.
| --hash=sha256:d6101ded078042a8f17959eccd9236fb7a9ca20d3b0098bbcb91533a5680d035 \ | ||
| --hash=sha256:e0697ece353e6239b90ee43a9231318302ad8353c70e6e45499fa52396debf90 \ | ||
| --hash=sha256:e0a1715e4f27355afd9570f3ea369735afc853a6c3951a6afe1f80d8569ad298 | ||
| protobuf==6.33.5 \ |
There was a problem hiding this comment.
While pinning protobuf to version 6.33.5 here correctly addresses the security vulnerability, this requirements.txt file is auto-generated by pip-compile. Having a bot edit it can lead to these changes being accidentally overwritten if a developer regenerates the file from requirements.in without being aware of this security pin.
A more robust approach would be to specify the constraint in requirements.in. You could add protobuf>=6.33.5 to requirements.in and regenerate requirements.txt. This makes the security fix explicit in your primary dependency file and ensures it's preserved across regenerations.
eb61472 to
c055db9
Compare
This PR contains the following updates:
==6.33.0→==6.33.5GitHub Vulnerability Alerts
CVE-2026-0994
A denial-of-service (DoS) vulnerability exists in google.protobuf.json_format.ParseDict() in Python, where the max_recursion_depth limit can be bypassed when parsing nested google.protobuf.Any messages.
Due to missing recursion depth accounting inside the internal Any-handling logic, an attacker can supply deeply nested Any structures that bypass the intended recursion limit, eventually exhausting Python’s recursion stack and causing a RecursionError.
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.