Skip to content

feat: Migrates the event-poi sample to js-api-samples.#1135

Merged
willum070 merged 6 commits intomainfrom
migrate-event-poi
Feb 25, 2026
Merged

feat: Migrates the event-poi sample to js-api-samples.#1135
willum070 merged 6 commits intomainfrom
migrate-event-poi

Conversation

@willum070
Copy link
Collaborator

This PR makes the following changes:

  • Migrates the event-poi sample to js-api-samples.
  • Refactors the app to use the gmp-map element and dynamic loading.
  • Updates the app to use the New Places API.
  • Simplifies the sample by removing directions functionality (too many things distract from the primary use case).

@snippet-bot
Copy link

snippet-bot bot commented Feb 24, 2026

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@willum070 willum070 requested a review from ReeseJones February 24, 2026 20:19
Copy link

@ReeseJones ReeseJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I have a few suggestions and questions.

Removed the infowindow-content div from the map.
Refactor initMap and showInfoWindow functions to correctly handle infowindow instance.
@willum070 willum070 requested a review from ReeseJones February 25, 2026 17:03
@willum070 willum070 requested a review from ReeseJones February 25, 2026 21:31
@willum070 willum070 merged commit ef8942c into main Feb 25, 2026
9 checks passed
@willum070 willum070 deleted the migrate-event-poi branch February 25, 2026 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants